Skip to content

Add implementation for missing-number#1330

Open
rishigoswamy wants to merge 1 commit intosuper30admin:masterfrom
rishigoswamy:master
Open

Add implementation for missing-number#1330
rishigoswamy wants to merge 1 commit intosuper30admin:masterfrom
rishigoswamy:master

Conversation

@rishigoswamy
Copy link

No description provided.

@super30admin
Copy link
Owner

No specific feedback provided. Refer to GitHub Comment.

@super30admin
Copy link
Owner

Strengths:

  • The code is well-structured and readable.
  • The student used binary search which is efficient.
  • The comments are detailed, though they describe a different problem.

Areas for improvement:

  • The student misunderstood the problem range. The problem says the range is 1 to n, but the student assumed 0 to n.
  • The condition in the binary search is not correct for the given problem.
  • The student should test the code with the provided examples to ensure correctness.

Final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants